widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

One important comment inline - please address. Otherwise lgtm. 

Diff comments:

> 
> === modified file 'src/logic/editor_game_base.cc'
> --- src/logic/editor_game_base.cc	2017-09-02 19:34:45 +0000
> +++ src/logic/editor_game_base.cc	2017-11-10 19:17:16 +0000
> @@ -73,7 +73,7 @@
>  }
>  
>  EditorGameBase::~EditorGameBase() {
> -	delete player_manager_.release();
> +	player_manager_.release();

This changes semantics. Before the object was deleted, now you leek memory. I think it is correct to just remove the line if player_manager_ is a smart pointer - it will get deleted.

>  }
>  
>  void EditorGameBase::think() {


-- 
https://code.launchpad.net/~widelands-dev/widelands/clang-tidy-round1/+merge/333560
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang-tidy-round1.