widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

My branch should work with passing to compile.sh the -a option. It only sets the default values - option on the command line still take priority. 

> Am 28.11.2017 um 18:37 schrieb GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>:
> 
> Review: Needs Fixing
> 
> I have an alternative branch linked to the bug:
> 
> https://code.launchpad.net/~widelands-dev/widelands/bug-1734843-asan-buildsystem
> 
> I think the branch you're proposing here doesn't make it easy to switch ASAN off for debug builds, but it also looks as if my branch is missing some cases.
> 
> We need to be able to create Debug builds without ASan for the following reasons:
> 
> 1. They are still very crashy at the moment, and we might need a debug build to test something that ASan won't let us reach
> 
> 2. I suspect that LeakSanitizer is producing false positives (c.f. https://bugs.launchpad.net/widelands/+bug/1734304).
> 
> 3. It will fail Travis
> 
> I think I spent an hour with RTFM an experimenting, trying to make my system build/run with ASan and without LSan, but nothing works. As long as we get the leak from Mesa, the test suite will fail even if we manage to fix all our code.
> -- 
> https://code.launchpad.net/~widelands-dev/widelands/fix_asan_building/+merge/334364
> You proposed lp:~widelands-dev/widelands/fix_asan_building for merging.


-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_asan_building/+merge/334364
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_asan_building.