widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1733212-game-information-update-fails into lp:widelands.

Commit message:
Fixed bug where table didn't sent selected() signal during multiselect

Requested reviews:
  GunChleoc (gunchleoc)
Related bugs:
  Bug #1733212 in widelands: "Game information update fails with multiple items"
  https://bugs.launchpad.net/widelands/+bug/1733212

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1733212-game-information-update-fails/+merge/335305
-- 
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1733212-game-information-update-fails.

=== modified file 'src/ui_basic/table.cc'
--- src/ui_basic/table.cc	2017-11-06 20:19:56 +0000
+++ src/ui_basic/table.cc	2017-12-18 08:48:04 +0000
@@ -426,7 +426,7 @@
  * Args: i  the entry to select
  */
 void Table<void*>::select(const uint32_t i) {
-	if (empty() || selection_ == i || i == no_selection_index())
+	if (empty() || i == no_selection_index())
 		return;
 
 	selection_ = i;