widelands-dev team mailing list archive

[TiborB <tiborb95@xxxxxxxxx>]

TiborB has proposed merging lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_fix/+merge/335640

The allows_seafaring rework some time ago damaged the functionality of AI seafaring. One of basic issue is that AI expected that if map is not seafaring (and brief time after game start it is by default so), it disabled all seafaring activities forever. So AI can have shipyard building ships forever and never stop it and never start preparation for expedition.
Entire concept of switching seafaring map ON/OFF in AI is bit fragile...
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands.