widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

You shoud make the -1 a constexpr, e.g.

> constexpr int16_t kInvalidForesterEntry = -1;

Now, after more thinking, forester_cache_ must be member of some gameobject.
Otherwise it may happen, that 

* a cache from some previous game is used for a different map.
* In case of a network game bothe side may have diffenter caches
  depending of the game they played before.

I checked out that code now and will think about a good location
for that cache and the functions. As I do not have much time 
dont expect me to come around with a solution soon.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1574379-forester-wit/+merge/336068
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1574379-forester-wit into lp:widelands.