widelands-dev team mailing list archive

[kaputtnik <somal@xxxxxxxx>]

kaputtnik has proposed merging lp:~widelands-dev/widelands/show_barbarian_not_yet_implemented into lp:widelands.

Commit message:
Show Not yet implemented after completing the barbarians campaign

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1744548 in widelands: "Campaigns: The dummy map "Not yet implemented" does not show up when barbarians campaign is completed"
  https://bugs.launchpad.net/widelands/+bug/1744548

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/show_barbarian_not_yet_implemented/+merge/336399

Show dummy map "Not yet implemented" in the campaign screen after the barbarians campaign has been completed.

Although the last message do inform the player that this was the last campaign for barbarians, it confuses a player if the "Not yet implemented" message does not show up.

-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/show_barbarian_not_yet_implemented into lp:widelands.

=== modified file 'data/campaigns/bar02.wmf/scripting/mission_thread.lua'
--- data/campaigns/bar02.wmf/scripting/mission_thread.lua	2017-07-12 06:13:59 +0000
+++ data/campaigns/bar02.wmf/scripting/mission_thread.lua	2018-01-21 10:31:21 +0000
@@ -375,7 +375,8 @@
    scroll_to_field(map:get_field(4,5))
 
    campaign_message_box(story_msg_7)
-
+   
+   p1:reveal_scenario("barbariantut02")
    p1:reveal_campaign("campsect1")
 end
 

=== modified file 'data/campaigns/campaigns.conf'
--- data/campaigns/campaigns.conf	2017-12-14 07:55:19 +0000
+++ data/campaigns/campaigns.conf	2018-01-21 10:31:21 +0000
@@ -73,6 +73,10 @@
 visible=0
 path="campaigns/bar02.wmf"
 
+[barbariantut02]
+name=_"Not yet implemented"
+visible=0
+path="campaigns/dummy.wmf"
 
 [empiretut00]
 name=_"The Strands of Malac’ Mor"