widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/remove_deprecated_allow_autosaving into lp:widelands.

Commit message:
Removed deprecated "allow_autosaving" functions from lua_root.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_deprecated_allow_autosaving/+merge/339492

This has been deprecated since before Build 18, so let's get rid.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/remove_deprecated_allow_autosaving into lp:widelands.

=== modified file 'src/scripting/lua_root.cc'
--- src/scripting/lua_root.cc	2017-11-25 18:29:22 +0000
+++ src/scripting/lua_root.cc	2018-02-25 09:36:11 +0000
@@ -85,7 +85,7 @@
 };
 const PropertyType<LuaGame> LuaGame::Properties[] = {
    PROP_RO(LuaGame, real_speed),    PROP_RO(LuaGame, time),
-   PROP_RW(LuaGame, desired_speed), PROP_RW(LuaGame, allow_autosaving),
+   PROP_RW(LuaGame, desired_speed),
    PROP_RW(LuaGame, allow_saving),  {nullptr, nullptr, nullptr},
 };
 
@@ -161,16 +161,6 @@
 	lua_pushboolean(L, get_game(L).save_handler().get_allow_saving());
 	return 1;
 }
-int LuaGame::set_allow_autosaving(lua_State* L) {
-	// WAS_DEPRECATED_BEFORE(build18), use allow_saving
-	get_game(L).save_handler().set_allow_saving(luaL_checkboolean(L, -1));
-	return 0;
-}
-int LuaGame::get_allow_autosaving(lua_State* L) {
-	// WAS_DEPRECATED_BEFORE(build18), use allow_saving
-	lua_pushboolean(L, get_game(L).save_handler().get_allow_saving());
-	return 1;
-}
 
 /*
  ==========================================================

=== modified file 'src/scripting/lua_root.h'
--- src/scripting/lua_root.h	2017-11-28 08:57:52 +0000
+++ src/scripting/lua_root.h	2018-02-25 09:36:11 +0000
@@ -57,8 +57,6 @@
 	int get_time(lua_State*);
 	int get_desired_speed(lua_State*);
 	int set_desired_speed(lua_State*);
-	int get_allow_autosaving(lua_State*);
-	int set_allow_autosaving(lua_State*);
 	int get_allow_saving(lua_State*);
 	int set_allow_saving(lua_State*);