widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands

To: mp+339493@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 26 Feb 2018 07:27:24 -0000
In-reply-to: <151955828206.29828.8941253047284372206.launchpad@ackee.canonical.com>
Reply-to: mp+339493@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Well, there are 2 bugs:

1. stack-buffer-overflow for invalid files. BTW this can also happen if somebody drops a random file in the save folder that doesn't have the expected format

2. Validating save files directly after saving them and showing a message to the user if this fails. That's a different issue and should be dealt with in a new branch.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow/+merge/339493
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands
From: GunChleoc, 2018-02-25