widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve compiles, review, partial test

OK for me, not sure where to find or trigger those bugmessages, though.

Diff comments:

> === modified file 'data/scripting/win_conditions/artifacts.lua'
> --- data/scripting/win_conditions/artifacts.lua	2017-05-12 11:30:43 +0000
> +++ data/scripting/win_conditions/artifacts.lua	2018-03-24 09:51:40 +0000
> @@ -52,7 +52,7 @@
>        local plrs = wl.Game().players
>        if #artifact_fields == 0 then
>           for idx, plr in ipairs(plrs) do
> -            send_message(plr, _"No Artifacts", p(_"There are no artifacts on this map. This should not happen. Please file a bug report on https://launchpad.net/widelands and specify your Widelands version and the map you tried to load."), {popup = true})
> +            send_message(plr, _"No Artifacts", p(_"There are no artifacts on this map. This should not happen. Please file a bug report on %s and specify your Widelands version and the map you tried to load."):bformat("https://wl.widelands.org/wiki/ReportingBugs/";), {popup = true})

No idea how to trigge that one :-)

>           end
>           return
>        end
> 
> === modified file 'utils/buildcat.py'
> --- utils/buildcat.py	2016-12-04 07:02:25 +0000
> +++ utils/buildcat.py	2018-03-24 09:51:40 +0000
> @@ -126,7 +126,7 @@
>  XGETTEXTOPTS += " -F -c\"* TRANSLATORS\""
>  # escaped double quotes are necessary for windows, as it ignores single quotes
>  XGETTEXTOPTS += " --copyright-holder=\"Widelands Development Team\""
> -XGETTEXTOPTS += " --msgid-bugs-address=\"https://bugs.launchpad.net/widelands\"";
> +XGETTEXTOPTS += " --msgid-bugs-address=\"https://wl.widelands.org/wiki/ReportingBugs/\"";

Where may I find this?

>  
>  # Options for xgettext when parsing Lua scripts
>  # Official Lua backend of xgettext does not support pgettext and npgettext right
> @@ -150,7 +150,7 @@
>  HEAD += "msgid \"\"\n"
>  HEAD += "msgstr \"\"\n"
>  HEAD += "\"Project-Id-Version: Widelands svnVERSION\\n\"\n"
> -HEAD += "\"Report-Msgid-Bugs-To: https://bugs.launchpad.net/widelands\\n\"\n";
> +HEAD += "\"Report-Msgid-Bugs-To: https://wl.widelands.org/wiki/ReportingBugs/\\n\"\n";

Where may I find this?

>  HEAD += "\"POT-Creation-Date: " + \
>      strftime('%Y-%m-%d %H:%M+0000', time_now) + "\\n\"\n"
>  HEAD += "\"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\\n\"\n"


-- 
https://code.launchpad.net/~widelands-dev/widelands/remove-external-websites/+merge/342024
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove-external-websites.