widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Replied to your comment.

Please set a commit message on top before you trigger the merge.

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2018-03-02 07:50:34 +0000
> +++ src/ai/defaultai.cc	2018-03-23 20:35:11 +0000
> @@ -2218,6 +2242,12 @@
>  	inputs[50] = (bakeries_count_ <= 1);
>  	inputs[51] = (numof_psites_in_constr > 8);
>  	inputs[52] = (numof_psites_in_constr < 8);
> +	inputs[53] = (mine_fields_stat.has_critical_ore_fields());
> +	inputs[54] = (!mine_fields_stat.has_critical_ore_fields());
> +	inputs[55] = (mine_fields_stat.count_types() == 4);

Yes, now I get it. I've just seen the number 4 multiple times here, so I figured it must have some special significance. Would it be interesting to have a constant here?

> +	inputs[56] = (mine_fields_stat.count_types() != 4);
> +	inputs[57] = (mine_fields_stat.has_critical_ore_fields());
> +	inputs[58] = (!mine_fields_stat.has_critical_ore_fields());
>  
>  	static int16_t needs_boost_economy_score = management_data.get_military_number_at(61) / 5;
>  	needs_boost_economy_score = management_data.get_military_number_at(61) / 5;


-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_mineable_fields/+merge/342006
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_mineable_fields.