widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

One question inline, will take a closer look later.

just brached this and will have a look.

Not sure who will be the payer for the other tribes military sites ;-) ?

Diff comments:

> 
> === modified file 'src/ui_basic/tabpanel.cc'
> --- src/ui_basic/tabpanel.cc	2017-08-08 17:39:40 +0000
> +++ src/ui_basic/tabpanel.cc	2018-04-07 17:36:19 +0000
> @@ -225,6 +225,9 @@
>  }
>  
>  bool TabPanel::remove_last_tab(const std::string& tabname) {
> +	if (tabs_.empty()) {
> +		return false;
> +	}

This can happen only in some rare, scripted scenarios, but yes.

>  	if (tabs_.back()->get_name() == tabname) {
>  		tabs_.pop_back();
>  		if (active_ > tabs_.size() - 1) {


-- 
https://code.launchpad.net/~widelands-dev/widelands/smaller_building_statistics/+merge/342828
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands.