← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/net-remove-tell_ip into lp:widelands

To: mp+343753@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 22 Apr 2018 09:24:17 -0000
In-reply-to: <152431190243.14257.14901080713412677444.launchpad@ackee.canonical.com>
Reply-to: mp+343753@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Code LGTM :)

Since GAME_OPEN and GAME_CONNECT aren't called that often, I think a bit of overhead is fine. I like he flexibility.
-- 
https://code.launchpad.net/~widelands-dev/widelands/net-remove-tell_ip/+merge/343753
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-remove-tell_ip.

References

[Merge] lp:~widelands-dev/widelands/net-remove-tell_ip into lp:widelands
From: Notabilis, 2018-04-21