widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

There is no calculation needed for warehouse performance - that's only relevant for productionsites. Rest LGTM.

Diff comments:

> 
> === modified file 'data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua'
> --- data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua	2018-04-27 17:02:13 +0000
> +++ data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua	2018-05-04 21:46:51 +0000
> @@ -18,11 +18,10 @@
>  
>  function building_helptext_note()
>     -- TRANSLATORS: Note helptext for a building
> -   return
> -      pgettext ("frisians_building", "The headquarters is your main building.")
> +   return pgettext ("frisians_building", "The headquarters is your main building.")
>  end
>  
>  function building_helptext_performance()
>     -- TRANSLATORS#: Performance helptext for a building
> -   return ""
> +   return no_performance_text_yet ()

Warehouses don't have any performant. Please revert these changes.

>  end


-- 
https://code.launchpad.net/~widelands-dev/widelands/translators-fix-bug-1768859/+merge/345116
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/translators-fix-bug-1768859.