widelands-dev team mailing list archive

[Notabilis <notabilis27@xxxxxx>]

Review: Approve

Diff looks good and text from the bug report is translated ingame.


Unrelated bug: When selecting a RTL language in the language drop down menu, the "The translation into ... is X % complete" text seems to be pretty messed up. Shall I open a bug report for this or is it part of "RTL support isn't that great yet"?

Diff comments:

> 
> === modified file 'src/logic/map_objects/tribes/tribes.cc'
> --- src/logic/map_objects/tribes/tribes.cc	2018-04-07 16:59:00 +0000
> +++ src/logic/map_objects/tribes/tribes.cc	2018-04-30 08:00:23 +0000
> @@ -68,8 +68,9 @@
>  
>  void Tribes::add_trainingsite_type(const LuaTable& table, const EditorGameBase& egbase) {
>  	i18n::Textdomain td("tribes");
> +	const std::string msgctxt = table.get_string("msgctxt");
>  	buildings_->add(new TrainingSiteDescr(
> -	   pgettext_expr(table.get_string("msgctxt").c_str(), table.get_string("descname").c_str()),
> +	   pgettext_expr(msgctxt.c_str(), table.get_string("descname").c_str()), msgctxt,

I don't understand why you are changing this. No objection, though.

>  	   table, egbase));
>  }
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1767919-trainingsite-messages/+merge/344813
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1767919-trainingsite-messages.