widelands-dev team mailing list archive

[Notabilis <notabilis27@xxxxxx>]

Review: Approve

Diff looks good and testing works as your descriptions say it should.

Not a regression due to this branch but still a bug: When having the, e.g., geologist-messages filter active and only a single message selected, the first message in the list is selected when a "collectors status update message" comes in, without deactivating the filter. This results in a message becoming selected which is not the new one. When we disable the archive mode in that case I think we should also disable the current filter (maybe only when the new message is not displayed by the current filter? Not sure).
Can also be fixed in another bug/branch but I guess it is only another if-clause in show_new_message().
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1672059-table-message-arrival/+merge/344926
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1672059-table-message-arrival.