← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/background_images into lp:widelands

 

Review: Approve review

As far as I can judge, this should work fine. Didn´t test it though.

I mainly checked the logic behind the code and found nothing that can go wrong; if it compiles and works, I guess there are no problems c++-wise either.
I reviewed style_manager.*, panel_styles.h, the drawing-related functions and the lua script; the rest is just moving some pieces of code and converting all UI elements to the new style definitions, isn´t it?
-- 
https://code.launchpad.net/~widelands-dev/widelands/background_images/+merge/337629
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/background_images.


References