← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1741779-map-description-edit-cutoff into lp:widelands

 

Review: Approve

Thanks, it is no longer crashing for me now.
One nit: In rendered_text.cc:183 the DEBUG-check is done twice, once there and once inside the called max_texture_size_for_font_rendering().

Diff comments:

> 
> === modified file 'src/graphic/text/rendered_text.cc'
> --- src/graphic/text/rendered_text.cc	2018-04-07 16:59:00 +0000
> +++ src/graphic/text/rendered_text.cc	2018-05-27 06:11:55 +0000
> @@ -183,7 +183,7 @@
>  #ifndef NDEBUG
>  		const int maximum_size = kMinimumSizeForTextures;
>  #else
> -		const int maximum_size = g_gr->max_texture_size();
> +		const int maximum_size = g_gr->max_texture_size_for_font_rendering();

Check is done twice here.

>  #endif
>  		const int tile_width = std::min(maximum_size, rect.width());
>  		const int tile_height = std::min(maximum_size, rect.height());


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1741779-map-description-edit-cutoff/+merge/345495
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1741779-map-description-edit-cutoff.


References