widelands-dev team mailing list archive

[hessenfarmer <stephan-lutz@xxxxxx>]

I agree to Nordfrieses last comment. 
Just ignore my commet about worker experience didn't see that it is the upgraded building.

We should document the new philosophy of the mines preferably in the RST section:
- now one ressource on the map delivers exactly one ware
- the probability is now calculated over the complete work cycle and implemented in the first mine command
- all working animations are put at the beginning of the command cycle.

I will try to playtest These values with the AI as this Change might have an Impact on AI due to different stats if depleted.

Thanks to WorldSavior for the changes

Diff comments:

> 
> === modified file 'data/tribes/buildings/productionsites/atlanteans/coalmine/init.lua'
> --- data/tribes/buildings/productionsites/atlanteans/coalmine/init.lua	2017-09-03 07:59:51 +0000
> +++ data/tribes/buildings/productionsites/atlanteans/coalmine/init.lua	2018-07-24 09:41:57 +0000
> @@ -57,17 +57,23 @@
>           -- TRANSLATORS: Completed/Skipped/Did not start mining coal because ...
>           descname = _"mining coal",
>           actions = {
> -            "sleep=45000",
> +            "sleep=40000",
>              "return=skipped unless economy needs coal",
>              "consume=smoked_fish,smoked_meat:2 atlanteans_bread:2",
>              "animate=working 20000",
> -            "mine=coal 4 100 5 2",
> -            "produce=coal:2",
> -            "animate=working 20000",
> -            "mine=coal 4 100 5 2",
> -            "produce=coal:2",
> -            "animate=working 20000",
> -            "mine=coal 4 100 5 2",
> +            "animate=working 20000",    
> +            "animate=working 20000",
> +            "mine=coal 4 100 35 2",

after or in this line a comment explaining the math behind the 35% Chance if depleted would be helpful for other developers. Alternatively we should add some Explanation to the RST section to get it into the Website documentation as well.

> +            "produce=coal",
> +            "sleep=2500",
> +            "mine=coal 4 100 1 2",
> +            "mine=coal 4 100 1 2",
> +            "mine=coal 4 100 1 2",
> +            "produce=coal:3",

Yes commenting would be fine.

> +            "sleep=2500",    
> +            "mine=coal 4 100 1 2",
> +            "mine=coal 4 100 1 2",
> +            "mine=coal 4 100 1 2",
>              "produce=coal:3"
>           }
>        },
> 
> === modified file 'data/tribes/buildings/productionsites/frisians/mead_brewery/init.lua'
> --- data/tribes/buildings/productionsites/frisians/mead_brewery/init.lua	2018-07-09 11:34:23 +0000
> +++ data/tribes/buildings/productionsites/frisians/mead_brewery/init.lua	2018-07-24 09:41:57 +0000
> @@ -80,7 +80,7 @@
>           -- TRANSLATORS: Completed/Skipped/Did not start brewing beer because ...
>           descname = _"brewing beer",
>           actions = {
> -            "return=skipped unless economy needs beer or workers need experience",
> +            "return=skipped unless economy needs beer",
>              "sleep=30000",

Forget this comment I got this wrong. everything in the code here is fine

>              "consume=barley water",
>              "animate=working 30000",


-- 
https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior.