← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands


I implemented your renaming suggestions. The resource Fish doesn´t need a timeout because it´s used only for geologist messages, not by buildings that mine this resource. timeout is therefore ignored for resources with detectable=false.

1) This is defined in Worker::geologist_update(). The geologist distinguishes between minable and non-minable nodes. If the two triangles attached to his start flag are both minable, he´ll investigate only minable spots, else only non-minable.

2) Resource indicators currently have to be named "resi_<resource_name><index>". This is defined in TribeDescr::get_resource_indicator(). The indicator´s name has to match exactly this format but no resource names are hardcoded.
This should be changed in a follow-up branch to either have the tribe specify a set of immovables for each resource (permitting tribe-specific indicators), or having each resource define a set of (not tribe-specific) indicators.
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands.