widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into lp:widelands.

Commit message:
Fixes for Debian-based software centers

- Add stock icon to appdata.xml (c.f. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857644)
- Change icon definition in .desktop to be a generic one

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1789023 in widelands: "Widelands package from Universe is not in the Software Center"
  https://bugs.launchpad.net/widelands/+bug/1789023

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center/+merge/353752
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into lp:widelands.

=== modified file 'debian/org.widelands.widelands.desktop'
--- debian/org.widelands.widelands.desktop	2018-07-28 11:03:59 +0000
+++ debian/org.widelands.widelands.desktop	2018-08-26 10:37:15 +0000
@@ -43,14 +43,14 @@
 Comment=A real-time build-up strategy game
 Comment[ar]=لعبة بناء إستراتيجية في الوقت الحقيقي
 Comment[bg]=Стратегическа игра за изграждане на цивилизация в реално време
-Comment[ca]=Un joc d'estratègia i construcció a temps real 
+Comment[ca]=Un joc d'estratègia i construcció a temps real
 Comment[cs]=Real-time budovatelská strategická hra
 Comment[da]=Et realtids opbygningsstrategispil
 Comment[de]=Echtzeitbasiertes Aufbau-Strategiespiel
 Comment[es]=Un juego de estrategia y construcción en tiempo real
 Comment[eu]=Denbora errealeko eraikuntza eta estrategia jokoa
 Comment[fi]=Reaaliaikainen strategiapeli
-Comment[fr]=Un jeu de stratégie et de construction en temps réel 
+Comment[fr]=Un jeu de stratégie et de construction en temps réel
 Comment[fy]=In strategysk bouwspultsje mei rinnende tiid
 Comment[gd]=Geama ro-innleachd togail fìor-ama
 Comment[hu]=Egy valós idejű, építkezős stratégiai játék
@@ -71,7 +71,7 @@
 Comment[sv]=Ett uppbyggnadsstrategispel i realtid
 Comment[uk]=Стратегічна гра у режимі реального часу
 Comment[zh_TW]=一款即時演變的策略遊戲
-Icon=/usr/share/games/widelands/data/images/logos/wl-ico-64.png
+Icon=widelands
 TryExec=widelands
 Exec=widelands
 Categories=Game;StrategyGame;

=== modified file 'debian/org.widelands.widelands.desktop.stub'
--- debian/org.widelands.widelands.desktop.stub	2018-07-28 11:03:59 +0000
+++ debian/org.widelands.widelands.desktop.stub	2018-08-26 10:37:15 +0000
@@ -3,7 +3,7 @@
 Type=Application
 Name=Widelands
 GENERIC_NAME_COMMENT_HOOK
-Icon=/usr/share/games/widelands/data/images/logos/wl-ico-64.png
+Icon=widelands
 TryExec=widelands
 Exec=widelands
 Categories=Game;StrategyGame;

=== modified file 'debian/widelands.appdata.xml'
--- debian/widelands.appdata.xml	2018-07-06 14:23:53 +0000
+++ debian/widelands.appdata.xml	2018-08-26 10:37:15 +0000
@@ -5,6 +5,7 @@
   <metadata_license>CC0-1.0</metadata_license>
   <project_license>GPL-2.0</project_license>
   <name>Widelands</name>
+  <icon type="stock">widelands</icon>
   <summary>A real-time build-up strategy game</summary>
   <summary xml:lang="ar">لعبة بناء إستراتيجية في الوقت الحقيقي</summary>
   <summary xml:lang="bg">Стратегическа игра за изграждане на цивилизация в реално време</summary>

=== modified file 'debian/widelands.appdata.xml.stub'
--- debian/widelands.appdata.xml.stub	2017-08-26 09:24:28 +0000
+++ debian/widelands.appdata.xml.stub	2018-08-26 10:37:15 +0000
@@ -5,6 +5,7 @@
   <metadata_license>CC0-1.0</metadata_license>
   <project_license>GPL-2.0</project_license>
   <name>Widelands</name>
+  <icon type="stock">widelands</icon>
   SUMMARY_DESCRIPTION_HOOK
   <screenshots>
     <screenshot type="default">