← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/rework-resource-indicators into lp:widelands


Review: Needs Fixing

I have done some in-game testing now - the code is almost ready, but still needs some tweaking. I'll add my comments for the graphics to the bug.

Code review of the C++ bits to follow.

Barbarian scenario 1 is fixed correctly, but the indicators are huge. They are also huge in the Encyclopedia. Please make them to scale - we can have bigger ones once we have mipmaps, which are pretty much ready but targeted for Build 21. https://code.launchpad.net/~widelands-dev/widelands/mipmaps

I have fixed the seafaring tutorial.

In-game help for mines is broken. I have fixed it for the Atlanteans, but the Barbarians don't follow the naming scheme. We can bzr mv the pictures, but I think the better solution would be to get the immovables by name and then get their representative_image.

Please rename the "png" folder to "pics" for consistency and fix the scripts accordingly. May sound like nitpicking, but it does make the file structure easier to navigate ;)
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rework-resource-indicators.