← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/appveyor_fix into lp:widelands

 

We have a new compiler warning on AppVeyor:

../src/graphic/gl/initialize.cc:101:9: warning: format '%s' expects argument of type 'char*', but argument 2 has type 'std::unique_ptr<glbinding::AbstractValue>::pointer' {aka 'glbinding::AbstractValue*'} [-Wformat=]
     log("%s", call.parameters[i].get());
         ^~~~  ~~~~~~~~~~~~~~~~~~~~~~~~
../src/graphic/gl/initialize.cc:107:9: warning: format '%s' expects argument of type 'char*', but argument 2 has type 'std::unique_ptr<glbinding::AbstractValue>::pointer' {aka 'glbinding::AbstractValue*'} [-Wformat=]
     log(" -> %s", call.returnValue.get());
         ^~~~~~~~  ~~~~~~~~~~~~~~~~~~~~~~

See if you can get something interesting to log from the objects - do they still have ->asString().c_str() available?
-- 
https://code.launchpad.net/~widelands-dev/widelands/appveyor_fix/+merge/354160
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/appveyor_fix into lp:widelands.


References