← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into lp:widelands


Diff is looking okay and the error messages are gone.

[Disclaimer: I don't know much about the lua interface.]
Basically the error message are avoided by not using get_int() anymore but using array_entries(). Is there a reason against fixing (?) get_int() (and others) so the usage of the table key is stored in the set accessed_keys_ as well, as is done inside array_entries() ? From the code it seems as if using any method except array_entries() will lead to the error message, which seems strange to me.
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into lp:widelands.