widelands-dev team mailing list archive

[Notabilis <notabilis27@xxxxxx>]

Notabilis has proposed merging lp:~widelands-dev/widelands/fix-codecheck-boost-sha1 into lp:widelands.

Commit message:
Including boost sha1 headers as system headers.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix-codecheck-boost-sha1/+merge/354633

CodeCheck is interpreting the boost headers in network/crypto.cc as local Widelands includes, since they are included as
  #include "boost/sha1.h"

Instead, they should be included as
  #include <boost/sha1.h>
since boost is a system header (or at least, not local to Widelands).
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix-codecheck-boost-sha1 into lp:widelands.

=== modified file 'src/network/crypto.cc'
--- src/network/crypto.cc	2018-09-10 06:11:01 +0000
+++ src/network/crypto.cc	2018-09-10 18:43:08 +0000
@@ -1,9 +1,9 @@
 #include "network/crypto.h"
 
 #if BOOST_VERSION > 106700
-#include "boost/uuid/detail/sha1.hpp"
+#include <boost/uuid/detail/sha1.hpp>
 #else
-#include "boost/uuid/sha1.hpp"
+#include <boost/uuid/sha1.hpp>
 #endif
 
 namespace crypto {