← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug1792297_worker_encyclopedia into lp:widelands


I have pushed a string fix.

I think the code for the collection of buildings needs fixing though. It will break as soon as somebody creates a tribe with more than 3 worker levels. I recommend the following:

1. Collect the buildings the worker works at directly in a table
2. Create a second table for the other buildings the worker may work at and only add buildings there that aren't listed in either table yet
3. Add the info to the result variable

This way, you'll also get rid of some code duplication.
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug1792297_worker_encyclopedia into lp:widelands.