← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1699852-compiler-warning into lp:widelands


I still get these:

.../src/logic/map_objects/tribes/ship.cc:705:3: warning: fallthrough annotation in
      unreachable code [-Wimplicit-fallthrough]

../src/ui_basic/fileview_panel.h:50:23: warning: non-static data member 'style_' of
      'FileViewPanel' shadows member inherited from type 'TabPanel' [-Wshadow-field]
        const UI::PanelStyle style_;

../src/wui/watchwindow.h:41:2: warning: '~WatchWindow' overrides a destructor but is not
      marked 'override' [-Winconsistent-missing-destructor-override]

../src/wui/seafaring_statistics_menu.cc:422:3: note: insert 'break;' to avoid

../src/wui/game_client_disconnected.h:29:1: warning: class 'GameHost' was previously
      declared as a struct [-Wmismatched-tags]
class GameHost;

../src/wui/waresdisplay.cc:388:13: warning: no previous extern declaration for
      non-static variable 'unit_suffixes' [-Wmissing-variable-declarations]
const char* unit_suffixes[] = {

Those switch warnigns are difficult, the rest should be easy....
... or shall we address them in a later branch?

Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1699852-compiler-warning into lp:widelands.