widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

2 comments that might or might not need attention.

Diff comments:

> 
> === modified file 'wiki/admin.py'
> --- wiki/admin.py	2017-12-03 11:43:47 +0000
> +++ wiki/admin.py	2018-10-03 11:14:32 +0000
> @@ -21,11 +21,7 @@
>      list_filter = ('title',)
>      ordering = ['-last_update']
>      fieldsets = (
> -        (None, {'fields': ('title', 'content', 'markup')}),
> -        ('Creator', {'fields': ('creator', 'creator_ip'),
> -                     'classes': ('collapse', 'wide')}),

I don't know what the classes do - you removed them for the articles too. If there are not needed anymore, this code is OK.

> -        # ('Group', {'fields': ('object_id', 'content_type'),
> -        #              'classes': ('collapse', 'wide')}),
> +        (None, {'fields': ('title', 'content', 'creator', 'markup')}),
>      )
>      raw_id_fields = ('creator',)
>      inlines = [InlineImages]
> 
> === modified file 'wlimages/models.py'
> --- wlimages/models.py	2016-12-13 18:28:51 +0000
> +++ wlimages/models.py	2018-10-03 11:14:32 +0000
> @@ -24,6 +24,7 @@
>      def create(self, **keyw):
>          """Makes sure that no image/revision pair is already in the
>          database."""
> +        print('franku in create')

Is this print still needed?

>          if 'name' not in keyw or 'revision' not in keyw:
>              raise IntegrityError('needs name and revision as keywords')
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/cleanup_ip_address_field/+merge/356061
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/cleanup_ip_address_field into lp:widelands-website.