widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug_1794339_center_wo_parent into lp:widelands

To: mp+355885@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 03 Oct 2018 19:02:38 -0000
In-reply-to: <153830408309.14069.854864769443366960.launchpad@ackee.canonical.com>
Reply-to: mp+355885@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Don't worry about the tabs, bunnybot will take care of those.

I'd still like to see the changes to window.cc reverted, because it will mask bugs like the one we're fixing here. Maybe use an assert or an exception to ensure that the parent is not null?
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug_1794339_center_wo_parent/+merge/355885
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug_1794339_center_wo_parent into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/bug_1794339_center_wo_parent into lp:widelands
From: Klaus Halfmann, 2018-09-30