widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve compile, review, test

Reproduced it on trunk, found it fixed here.

Looks like these monster switches in gameclient.cc deserve a refactoring :-)

One Comment inline.

All fine for me.

@bunnybot merge

Diff comments:

> === modified file 'src/network/gameclient.cc'
> --- src/network/gameclient.cc	2018-04-21 10:57:12 +0000
> +++ src/network/gameclient.cc	2018-09-26 06:07:24 +0000
> @@ -584,7 +584,6 @@
>  		// New map was set, so we clean up the buffer of a previously requested file
>  		if (file_)
>  			delete file_;
> -		Notifications::publish(NoteGameSettings(NoteGameSettings::Action::kMap));

Moved this to NETCMD_SETTING_ALLPLAYERS...

>  		break;
>  	}
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1791426-multiplayer-map-change/+merge/355622
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1791426-multiplayer-map-change.