widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM, just 1 tiny nit - we have an extra indent that we could lose

Diff comments:

> 
> === modified file 'threadedcomments/views.py'
> --- threadedcomments/views.py	2018-04-05 07:30:42 +0000
> +++ threadedcomments/views.py	2018-10-05 16:44:16 +0000
> @@ -87,25 +89,19 @@
>      if form.is_valid():
>          new_comment = form.save(commit=False)
>          if not edit_id:
> -            new_comment.ip_address = get_real_ip(request)
>              new_comment.content_type = get_object_or_404(
>                  ContentType, id=int(content_type))
>              new_comment.object_id = int(object_id)
> -        if model == ThreadedComment:
> -            new_comment.user = request.user
> +
> +        new_comment.user = request.user
> +
>          if parent_id:
>              new_comment.parent = get_object_or_404(model, id=int(parent_id))
>          new_comment.save()
> -        if model == ThreadedComment:
> -            if add_messages:
> +        if add_messages:
>                  request.user.message_set.create(

Get rid of 1 indent level

>                      message='Your message has been posted successfully.')
> -        else:
> -            request.session['successful_data'] = {
> -                'name': form.cleaned_data['name'],
> -                'website': form.cleaned_data['website'],
> -                'email': form.cleaned_data['email'],
> -            }
> +
>          if ajax == 'json':
>              return JSONResponse([new_comment, ])
>          elif ajax == 'xml':


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/cleanup_threadedcomments/+merge/356200
Your team Widelands Developers is subscribed to branch lp:widelands-website.