widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands.

Commit message:
Fix initialization of last player dropdown in editor player menu

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695

Player number start with 1, not with 0...
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands.

=== modified file 'src/editor/ui_menus/player_menu.cc'
--- src/editor/ui_menus/player_menu.cc	2018-08-28 18:27:59 +0000
+++ src/editor/ui_menus/player_menu.cc	2018-10-15 05:06:59 +0000
@@ -184,7 +184,7 @@
 		}
 
 		plr_tribe->select(
-		   (p < map.get_nrplayers() && Widelands::tribe_exists(map.get_scenario_player_tribe(p))) ?
+		   (p <= map.get_nrplayers() && Widelands::tribe_exists(map.get_scenario_player_tribe(p))) ?
 		      map.get_scenario_player_tribe(p) :
 		      "");
 		plr_tribe->selected.connect(