← Back to team overview

widelands-dev team mailing list archive

[Merge] lp:~widelands-dev/widelands/frisian-buildings into lp:widelands

 

Benedikt Straub has proposed merging lp:~widelands-dev/widelands/frisian-buildings into lp:widelands.

Commit message:
Improved graphics for the frisian sentinel

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1764606 in widelands: "Frisian building models are too dark"
  https://bugs.launchpad.net/widelands/+bug/1764606

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/frisian-buildings/+merge/357056

Graphics-only change. The sentinel looks too similar to the outpost for my liking, so I downgraded it a bit.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/frisian-buildings into lp:widelands.
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_0.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_0.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_0.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_0_pc.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_0_pc.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_0_pc.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_1.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_1.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_1.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_1_pc.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_1_pc.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_1_pc.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_2.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_2.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_2.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_2_pc.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_2_pc.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_2_pc.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_3.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_3.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_3.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/idle_3_pc.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/idle_3_pc.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/idle_3_pc.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/init.lua'
--- data/tribes/buildings/militarysites/frisians/sentinel/init.lua	2018-07-12 19:37:48 +0000
+++ data/tribes/buildings/militarysites/frisians/sentinel/init.lua	2018-10-18 09:16:14 +0000
@@ -23,12 +23,12 @@
    animations = {
       idle = {
          pictures = path.list_files (dirname .. "idle_?.png"),
-         hotspot = {41, 53},
+         hotspot = {33, 53},
          fps = 10,
       },
       unoccupied = {
          pictures = path.list_files (dirname .. "unoccupied_?.png"),
-         hotspot = {41, 53},
+         hotspot = {33, 53},
       },
    },
 

=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/menu.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/menu.png	2018-07-15 11:28:49 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/menu.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/unoccupied_0.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/unoccupied_0.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/unoccupied_0.png	2018-10-18 09:16:14 +0000 differ
=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/unoccupied_0_pc.png'
Binary files data/tribes/buildings/militarysites/frisians/sentinel/unoccupied_0_pc.png	2018-07-12 19:37:48 +0000 and data/tribes/buildings/militarysites/frisians/sentinel/unoccupied_0_pc.png	2018-10-18 09:16:14 +0000 differ

Follow ups