widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1769426-libreadline into lp:widelands.

Commit message:
Add libreadline7.dll to Inno Setup script. Some Windows machines seem to need it.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1769426 in widelands: "Some windows machines complain about missing libreadline7.dll"
  https://bugs.launchpad.net/widelands/+bug/1769426

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1769426-libreadline/+merge/358362

Not tested - let's wait for AppVeyor. I have an e-mail contact with an affected machine.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1769426-libreadline into lp:widelands.

=== modified file 'utils/win32/innosetup/Widelands.iss'
--- utils/win32/innosetup/Widelands.iss	2018-09-18 13:52:22 +0000
+++ utils/win32/innosetup/Widelands.iss	2018-11-06 05:57:30 +0000
@@ -140,6 +140,7 @@
 Source: {#DLLFolder}\libiconv-2.dll;                        DestDir: {app};            Flags: ignoreversion;                                                       Components: "Widelands"
 Source: {#DLLFolder}\libgraphite2.dll;                      DestDir: {app};            Flags: ignoreversion;                                                       Components: "Widelands"
 Source: {#DLLFolder}\libpcre-1.dll;                         DestDir: {app};            Flags: ignoreversion;                                                       Components: "Widelands"
+Source: {#DLLFolder}\libreadline7.dll;                      DestDir: {app};            Flags: ignoreversion;                                                       Components: "Widelands"
 Source: {#BuildFolder}\build\src\widelands.exe;   DestDir: {app};            Flags: ignoreversion;                                                       Components: "Widelands"
 Source: {#BuildFolder}\ChangeLog;                                 DestDir: {app};            Flags: ignoreversion; DestName: ChangeLog.txt;                              Components: "Widelands"
 Source: {#BuildFolder}\COPYING;                                   DestDir: {app};            Flags: ignoreversion; DestName: COPYING.txt;                                Components: "Widelands"