← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/django_staticfiles into lp:widelands-website

 

When clicking on a screenshot, it won't bring up the lightbox with the bigger version. I don't have admin rights on the Alpha site, so I can't add a new one to test if it's just an issue with old data.

I have added some diff comments.

We should also grep for "MEDIA_URL" and "foreign" to make sure it's clean - I can't do that right now, because bzr keeps crapping out on this machine.

Diff comments:

> 
> === modified file 'README.txt'
> --- README.txt	2018-05-09 06:02:44 +0000
> +++ README.txt	2018-11-23 20:43:50 +0000
> @@ -99,6 +99,17 @@
>  
>  Now everything should work.
>  
> +Runnning with DBUG=False
> +------------------------
> +In case you want to test the site with the setting DEBUG=False, you might
> +notice that at least the admin site misses all css. To fix this run:

misses -> is missing

> +
> +  $ ./manage.py collectstatic -l
> +
> +This will create symbolic links (-l) to static contents of third party apps in
> +the folder defined by STATIC_ROOT. See:
> +https://docs.djangoproject.com/en/dev/ref/contrib/staticfiles/#collectstatic
> +
>  Accessing the website from other machines
>  -----------------------------------------
>  
> 
> === modified file 'local_urls.py.sample'
> --- local_urls.py.sample	2018-05-24 07:23:08 +0000
> +++ local_urls.py.sample	2018-11-23 20:43:50 +0000
> @@ -6,16 +6,21 @@
>  # Don't use this file on the server!
>  
>  local_urlpatterns = [
> +   # Files uploaded by users   
>     url(r'^wlmedia/(?P<path>.*)$',
>         serve,
> -       {'document_root': settings.STATIC_MEDIA_PATH},
> +       {'document_root': settings.MEDIA_ROOT},
>         name='static_media'),
> -   url(r'^media/(?P<path>.*)$',
> +   # Static files if DEBUG=False. Use the 'collectstatic' command to fetch them
> +   url(r'^static/(?P<path>.*)$',
>         serve,
> -       {'document_root': settings.STATIC_MEDIA_PATH},
> -       name='static_media_pybb'),
> +       {'document_root': settings.STATIC_ROOT},
> +       name='static_media_foreign'),

Do you still want "foreign" here?

> +   # HTML documentation created by ./manage.py create_docs
>     url(r'^documentation/(?P<path>.*)$',
>         serve,
> -       {'document_root': path.join(settings.STATIC_MEDIA_PATH, 'documentation/html')},
> -       name='documentation'),
> +       {'document_root': path.join(
> +         settings.MEDIA_ROOT, 'documentation/html')},
> +       name='documentation')
>  ]
> +


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/django_staticfiles/+merge/359345
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/django_staticfiles into lp:widelands-website.


References