widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve code

Code LGTM, no tested yet. 1 small nit for a comment.

Diff comments:

> === modified file 'src/network/gamehost.cc'
> --- src/network/gamehost.cc	2018-11-06 17:05:10 +0000
> +++ src/network/gamehost.cc	2018-11-28 22:54:33 +0000
> @@ -1939,6 +1949,8 @@
>  	Client peer;
>  	assert(d->net != nullptr);
>  	while (d->net->try_accept(&peer.sock_id)) {
> +		// Should only happen if the game has not be started yet

be -> been

> +		assert(d->game == nullptr);
>  		peer.playernum = UserSettings::not_connected();
>  		peer.syncreport_arrived = false;
>  		peer.desiredspeed = 1000;


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1805325-joining-lan-games.