← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~hjd/widelands/packaging-19-repack-6 into lp:widelands


Re-added the commented part, and documented them in the changelog. I wasn't aware some of them were done intentionally. With them listed in the changelog it should be easier to avoid similar mistakes in the future and hopefully they can be added to Debian when the next release happens, further reducing the delta.

Diff comments:

> === modified file 'debian/widelands.appdata.xml'
> --- debian/widelands.appdata.xml	2018-11-02 08:04:23 +0000
> +++ debian/widelands.appdata.xml	2018-11-25 16:21:32 +0000
> @@ -4,7 +4,6 @@
>    <id>org.widelands.widelands.desktop</id>
>    <metadata_license>CC0-1.0</metadata_license>
>    <project_license>GPL-2.0</project_license>
> -  <icon type="stock">widelands</icon>

It shows up in Debian's gnome-software which doesn't include this line. :S It also looks like they fixed the icon by adjusting the desktop file (https://salsa.debian.org/games-team/widelands/merge_requests/1/diffs)

Though, I'm not familiar enough with this to argue over it, and given the back-and-forth we've had with appdata it seems safer to leave it in :)

>    <name>Widelands</name>
>    <name xml:lang="ko">와이드랜드</name>
>    <summary>A real-time build-up strategy game</summary>

Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/packaging-19-repack-6 into lp:widelands.