← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1810062-territorial-calculations into lp:widelands

 

Code looks very good. The effect is the bigger the more port spaces are available. As we had walked them probably twice before now we walk them only if they weren' touched. by the starting positions walk. 

Thanks a lot for doing a great job.

If we want to count only walkable fields in the statistics this might be simply done by adding a maxcaps walkable check to line

https://bazaar.launchpad.net/~widelands-dev/widelands/bug-1810062-territorial-calculations/view/head:/src/logic/game.cc#L973

However in my opinion the stats should stay as they are, as I am trying sometimes to conquer the complete map and compare the value against the result of mapwidth * mapheight. 

Only thing we could probably do is adding the term valuable to the territorial status messages to clearly distinguish that not all field are taken into account but only valuable fields. 
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1810062-territorial-calculations/+merge/361366
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1810062-territorial-calculations.


References