widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

To: mp+363729@xxxxxxxxxxxxxxxxxx
From: Benedikt Straub <benedikt-straub@xxxxxx>
Date: Wed, 27 Feb 2019 14:47:09 -0000
In-reply-to: <155127740192.5515.16521508938237818955.launchpad@ackee.canonical.com>
Reply-to: mp+363729@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Tested it.
The log says »ERROR: Wrong SDL_BYTESPERPIXEL, expected 4 but got 1« as expected. 
But no message box appears, the program exits immediately.

By the way, the assert could be removed now, right? Since the triggering failure is now caught beforehand.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
From: GunChleoc, 2019-02-27