widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands.

Commit message:
After successfully saving a map, mark it as not needing saving.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1820036 in widelands: "Editor:  Asserts the map hasn't been saved directly after saving"
  https://bugs.launchpad.net/widelands/+bug/1820036

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1820036-map-saving-prompt/+merge/364705

The marker got lost when we added some safeguards for file system access while saving.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands.

=== modified file 'src/editor/ui_menus/main_menu_save_map.cc'
--- src/editor/ui_menus/main_menu_save_map.cc	2019-02-23 11:00:49 +0000
+++ src/editor/ui_menus/main_menu_save_map.cc	2019-03-18 21:12:55 +0000
@@ -333,6 +333,7 @@
 	if (error == GenericSaveHandler::Error::kSuccess ||
 	    error == GenericSaveHandler::Error::kDeletingBackupFailed) {
 		egbase.get_ibase()->log_message(_("Map saved"));
+		eia().set_need_save(false);
 		return true;
 	}