← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/editor-resize-map into lp:widelands

 

Thanks for the review, implemented your suggestions

Diff comments:

> 
> === modified file 'src/editor/ui_menus/tool_menu.cc'
> --- src/editor/ui_menus/tool_menu.cc	2019-02-23 11:00:49 +0000
> +++ src/editor/ui_menus/tool_menu.cc	2019-04-07 17:11:51 +0000
> @@ -82,7 +84,10 @@
>  		                          5 :
>  		                          &current == &parent.tools()->set_port_space ?
>  		                          6 :
> -		                          &current == &parent.tools()->set_origin ? 7 : 0);
> +		                          &current == &parent.tools()->set_origin ?

MY compiler doesn´t accept switch-statements with non-integer types, so not possible :(

> +		                          7 :
> +		                          &current == &parent.tools()->resize ?
> +		                          8 : 0);
>  	}
>  
>  	radioselect_.changed.connect(boost::bind(&EditorToolMenu::changed_to, this));


-- 
https://code.launchpad.net/~widelands-dev/widelands/editor-resize-map/+merge/365638
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/editor-resize-map into lp:widelands.


References