← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1489295-mine-is-exhausted into lp:widelands

 

I don't get this.

According to your log the Production result was set properly so why do we need the empty string check?

and why doing it that complicated 

why not 

if ( ps.production_result() != ps.descr().out_of_resource_heading() || ps.descr().out_of_resource_heading().empty()) {
			ps.set_production_result(result_string);
		}
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1489295-mine-is-exhausted/+merge/366727
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1489295-mine-is-exhausted.


References