widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands

To: mp+366743@xxxxxxxxxxxxxxxxxx
From: Klaus Halfmann <klaus.halfmann@xxxxxxxx>
Date: Fri, 03 May 2019 12:07:15 -0000
In-reply-to: <155669634970.13969.6717326650851140377.codereview@gac.canonical.com>
Reply-to: mp+366743@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

* Used parent instead of This.
* moved all Variables into Impl

About that -2 magic: I got lost in finding the sematics of user/player etc.
I added a TODO comment with our best guess by now.

I am at the End of my vacation (sigh) so lets get this in before it
starts lingering around for too long.
-- 
https://code.launchpad.net/~widelands-dev/widelands/refactor_gameclient/+merge/366743
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands.

References

Re: [Merge] lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands
From: Klaus Halfmann, 2019-05-01