← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands


Using unique_ptr<GameTips> is unneeded, this is only a helper class neede to as long as some progress dialog is open, so using normal scope is ok. 
(We should actually cleanup that usage, some other time)

The Problem is the owenership of UI::ProgressWindow* loader

The disconnect code try to close the last 'modal' window.
In case of the loader this is incorrect.

Not sure how to cleanup tis messs by now

Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands.