← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/show_user_posts into lp:widelands-website

 

Review: Approve

A few string nits. Feel free to merge & deploy when you have addressed them.

Diff comments:

> === added file 'pybb/templates/pybb/all_user_posts.html'
> --- pybb/templates/pybb/all_user_posts.html	1970-01-01 00:00:00 +0000
> +++ pybb/templates/pybb/all_user_posts.html	2019-05-10 06:24:15 +0000
> @@ -0,0 +1,38 @@
> +{% extends 'pybb/base.html' %}
> +{% load custom_date %}
> +{% load pagination_tags %}
> +{% block title %}
> +    Posts by {{ this_user }}- {{ block.super }}

{{ this_user }}- -> {{ this_user }} -?

> +{% endblock title %}
> +
> +{% block content_header %}
> +    <h1>Posts by {{ this_user }}</h1>
> +{% endblock %}
> +
> +{% block content_main %}
> +<div class="blogEntry">
> +<p>{{ this_user }} had {{ posts|length }} post{{ posts|length|pluralize }} written.</p>

x has written n post(s).

"had" would mean that he does not have that number of posts any more.

> +{% autopaginate posts 30 %}
> +{% paginate %}
> +<table class='forum'>
> +  <thead>
> +    <tr>
> +      <th style="text-align: left; width: 12em;">Date</th>
> +      <th style="text-align: left; width: 14em;">Forum</th>
> +      <th style="text-align: left; width: 24em;">Topic</th>
> +      <th style="text-align: left;">Post{{ posts|length|pluralize }}</th>
> +    </tr>
> +  </thead>
> +  <tbody>
> +    {% for post in posts %}
> +    <tr class="{% cycle 'odd' 'even' %}">
> +      <td class='post'>{{ post.created|custom_date:user }}</td>
> +      <td class='post'><a href="{% url 'pybb_topic' post.topic.id %}">{{ post.topic.forum }}</a></td>
> +      <td class='post'><a href="{% url 'pybb_forum' post.topic.forum.id %}">{{ post.topic }}</a></td>
> +      <td class='post'><a href="{{ post.get_absolute_url }}">"{{ post.body_text|truncatechars:80 }}"</a></td>
> +    </tr>
> +    {% endfor %}
> +  </tbody>
> +</table>
> +</div>
> +{% endblock %}


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/show_user_posts/+merge/367237
Your team Widelands Developers is subscribed to branch lp:widelands-website.


References