widelands-dev team mailing list archive

[TiborB <tiborb95@xxxxxxxxx>]

I have one objection, see comment in code

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2019-04-20 05:44:37 +0000
> +++ src/ai/defaultai.cc	2019-05-15 06:30:23 +0000
> @@ -4971,8 +4988,8 @@
>  
>  			if (calculate_stocklevel(wt) < target ||
>  			    site_needed_for_economy == BasicEconomyBuildingStatus::kEncouraged) {
> -				if (bo.max_needed_preciousness < preciousness) {
> -					bo.max_needed_preciousness = preciousness;
> +				if (bo.max_needed_preciousness < 2 * preciousness) {

Why are you doing this? "max preciousness" should be what it says - the highest preciousness. This only confuses terminology...
If you feel this is needed, please do it outside of "max_needed_preciousness" variable please....

> +					bo.max_needed_preciousness = 2 * preciousness;
>  				}
>  				if (site_needed_for_economy == BasicEconomyBuildingStatus::kEncouraged) {
>  					bo.max_needed_preciousness +=


-- 
https://code.launchpad.net/~widelands-dev/widelands/AI-fixes/+merge/367309
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/AI-fixes.