widelands-dev team mailing list archive

[hessenfarmer <stephan-lutz@xxxxxx>]

sorry was busy yesterday with real life. 

Code looks good. but should be tested. 
one small nit in the diff

Diff comments:

> 
> === modified file 'data/tribes/buildings/trainingsites/barbarians/battlearena/init.lua'
> --- data/tribes/buildings/trainingsites/barbarians/battlearena/init.lua	2019-05-19 11:25:28 +0000
> +++ data/tribes/buildings/trainingsites/barbarians/battlearena/init.lua	2019-05-30 13:42:19 +0000
> @@ -90,10 +90,12 @@
>           descname = pgettext("barbarians_building", "upgrading soldier evade from level 0 to level 1"),
>           actions = {
>              "checksoldier=soldier evade 0", -- Fails when aren't any soldier of level 0 evade
> -            "sleep=15000",
> +            "return=failed unless site has barbarians_bread:2",

checks for to much bread as only one needed for this training

> +            "return=failed unless site has fish,meat",
> +            "return=failed unless site has beer_strong",
> +            "animate=working 30000",
>              "checksoldier=soldier evade 0", -- Because the soldier can be expelled by the player
>              "consume=barbarians_bread fish,meat beer_strong",
> -            "animate=working 15000",
>              "train=soldier evade 0 1"
>           }
>        },


-- 
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/failed_skipped_10s.