widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

I expect some followup change on the website then.
Widelands will always read older Maps.

Did another review with a look into the complete code.
(We need some Widelands historian for all this legacy :-)

A bit more documentation would help.

Diff comments:

> 
> === modified file 'src/map_io/widelands_map_loader.cc'
> --- src/map_io/widelands_map_loader.cc	2019-05-26 03:14:41 +0000
> +++ src/map_io/widelands_map_loader.cc	2019-06-22 11:22:28 +0000
> @@ -198,7 +202,7 @@
>  		log("Reading Map Version Data ... ");
>  		{
>  			MapVersionPacket p;
> -			p.read(*fs_, egbase, is_game, *mol_);
> +			p.read(*fs_, egbase, is_game, old_world_name_.empty());

Please add a command what this old_world_name_ is (rep. was)

>  		}
>  		log("took %ums\n ", timer.ms_since_last_query());
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/elk_moose/+merge/369201
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/elk_moose into lp:widelands.