← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands


Thanks for testing!

> Not nice, you open the tool popup toheeter with the tool-size window.

I do not understand what you mean here - please explain more.

> The zoom Icons look a bit rough?

The images are just placeholders, a graphic artist will need to make proper ones.

> Via the Editor-Main-Menu one can open all windows at the same time,
> this cries for all kinds of Errors.

This was also possible previously - you can open them all in trunk too. Certainly worth thinking about, but not in this branch.

> Tutorial did not wait until I actually used te "Show Buiding Spaces" menu

That bit is a bit different from trunk - the tutorial switched them on and off for you so that you can see how it's done, and then you have to do it yourself. In trunk, you have to do it yourself immediatel

How is the timing for you regarding the wait between opening the menu and clicking on the entry?

> Tutoral crashes with assert AND ASAN:
> ...
> Clicking tab 'small'
> Pressing button 'barbarians_lumberjacks_hut'
> Clicking button 'barbarians_lumberjacks_hut'
> Fatal exception: [../src/graphic/image_io.h:35] Image not found:
> images/wui/menus/menu_stock.png
> FATAL ERROR - game crashed. Attempting emergency save.
> Game: Writing Preload Data ... AddressSanitizer:DEADLYSIGNAL
> =================================================================
> ==18043==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc
> 0x00010d04de4b bp 0x7ffee53a0910 sp 0x7ffee53a0460 T0)
> ==18043==The signal is caused by a READ memory access.
> ==18043==Hint: address points to the zero page.
>     #0 0x10d04de4a in Widelands::GamePreloadPacket::write(FileSystem&,
> Widelands::Game&, Widelands::MapObjectSaver*) game_preload_packet.cc:114
>     #1 0x10d052b08 in Widelands::GameSaver::save() game_saver.cc:51
> Looks like the emergency save stumbeld over already corrupt data?

That's an image file that got moved, and then I merged in new code for the construction sites, which still pointed to the old image location. Fixed.

> It think there is a lot to fix, aynthing more I can reasonably test?

Testing needs to be done on the editor and the 2 tutorials, and maybe play a normal game too. And the dropdowns in the Options screen and the multiplayer setup should still be OK.
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/toolbar-dropdown-scripting-review-only.