widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/new-shipping into lp:widelands

To: mp+371155@xxxxxxxxxxxxxxxxxx
From: Benedikt Straub <benedikt-straub@xxxxxx>
Date: Tue, 27 Aug 2019 14:27:46 -0000
In-reply-to: <156542973400.27375.2796203215381834076.launchpad@ackee.canonical.com>
Reply-to: mp+371155@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

The OPtr is just a wrapper for a MapObject. I use OPtr<PortDock> rather than PortDock* to avoid segfaults when the portdock is destroyed. The == comparison compares serials, so it´s 100% safe to use.
I found a potential cause for this assert in the way superfluous or invalid destinations are discarded, please check whether you can still reproduce it now…
-- 
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/new-shipping.

References

[Merge] lp:~widelands-dev/widelands/new-shipping into lp:widelands
From: Benedikt Straub, 2019-08-10