← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands


I have pushed another commit with code review. I'm done with this for now. I also did a grep on data and test for lua changes, and it looks like we didn't miss anything.

The following 2 bits in the code are a bit complicated and could do with testing:

* worker creation over multiple economies
* Barracks
* ferry paths, especially around coasts

For ferry oceans separated very narrowly, how about allowing portage there? This might simplify the CheckStepFerry.
Just an idea, don't feel obligagted to implement this.

The following new Lua functions don't have tests yet (we can implement those in a follow-up branch though):
* get_waterway_max_length
* set_waterway_max_length
* get_ferry

Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ferry.